test(cursor): verify Grok 4.6 routing - #1547
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe change documents verified Cursor Grok 4.6 support and expands tests for model discovery, context windows, reasoning efforts, wire IDs, Fast variants, and effort clamping. ChangesCursor Grok 4.6 support
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Review readiness checklist
2/4 boxes ticked. This PR stays in draft until every box above is ticked. |
…540/grok46-publish
|
@coderabbitai review |
|
|
Tip For best results, initiate chat on the files or code changes.
🧠 Learnings usedYou are interacting with an AI system. |
|
Tip For best results, initiate chat on the files or code changes.
🧠 Learnings usedYou are interacting with an AI system. |
Wibias
left a comment
There was a problem hiding this comment.
The runtime behavior is unchanged and CI is green, but the new provenance test currently overstates what was actually verified. Please separate observed Cursor wire IDs from inferred/announced tier behavior so the regression suite does not manufacture evidence for low/medium (or Fast transport) that the PR says was not directly account-verified.
The provenance blocker was addressed in c53d218: the recorded Grok 4.6 fixture now contains only the account-observed high wire ID, with low/medium and Fast explicitly separated as announced/inherited behavior rather than recorded wire evidence. Clearing the old changes-requested state; final approval still waits for rebase onto current dev and exact-head CI.
Wibias
left a comment
There was a problem hiding this comment.
Re-review on exact head c53d218: the previous provenance blocker is resolved. The recorded Grok 4.6 fixture now contains only the account-observed cursor-grok-4.6-high; low/medium and Fast are clearly separated as announced/inherited behavior rather than claimed wire captures. I found no new correctness issue in the four-file diff. I’m not approving this head yet because the PR is still draft and based on c125b61 while current dev is 75cacdf (38 commits ahead). None of the four PR files changed across that dev advance, so the rebase should be mechanical, but please rebase and let exact-head CI run before final approval.
Summary
cursor-grok-4.6-highrun.cursor-grok-4.6-highwire ID, the announced low/medium/high ladder, and the inherited parameterized Fast encoding.Source: https://x.ai/news/grok-4-6
Verification
bun install --frozen-lockfilebun test tests/cursor-discovery.test.ts tests/cursor-effort-suffix.test.ts— 23 passed, 0 failedbun run typecheckbun run test— 11,388 passed, 11 skipped, 0 failedChecklist
Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
All CI tests are green on my local testing.
I pushed my PR to the latest dev commit.
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.